[U-Boot] [PATCH 2/2] musb: sunxi: Implement dfu_usb_get_reset()

Ian Campbell ijc+uboot at hellion.org.uk
Sun Oct 25 13:40:45 CET 2015


On Sun, 2015-10-25 at 12:46 +0100, Albert ARIBAUD wrote:
> > > +static u8 last_int_usb;
> > > +
> > > +bool dfu_usb_get_reset(void)
> > > +{
> > > +	return !!(last_int_usb & MUSB_INTR_RESET);
> > 
> > The !! is not needed.
> 
> Except if you want to be sure that you return 0 or 1 rather than 0 or
> (1 << something).

Doesn't the bool return type already cause that to happen? (from the
PoV of the caller at least)

Ian.


More information about the U-Boot mailing list