[U-Boot] [PATCH v5 02/23] spi: zynq_[q]spi: Use GENMASK macro

[Siva Durga Prasad Paladugu]

> -----Original Message-----
> From: Jagan Teki [mailto:jteki at openedev.com]
> Sent: Saturday, October 24, 2015 9:09 AM
> To: u-boot at lists.denx.de
> Cc: Jagan Teki; Siva Durga Prasad Paladugu; Michal Simek
> Subject: [PATCH v5 02/23] spi: zynq_[q]spi: Use GENMASK macro
> 
> GENMASK macro used on zynq_spi.c and zynq_qspi.c
> 
> GENMASK is used to create a contiguous bitmask([hi:lo]).
> Ex: (0x7 << 3) => GENMASK(5, 3)
> 
> Cc: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> Cc: Michal Simek <michal.simek at xilinx.com>
> Signed-off-by: Jagan Teki <jteki at openedev.com>
Acked-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> ---
>  drivers/spi/zynq_qspi.c | 8 ++++----
>  drivers/spi/zynq_spi.c  | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/spi/zynq_qspi.c b/drivers/spi/zynq_qspi.c index
> dd530a1..64b4eea 100644
> --- a/drivers/spi/zynq_qspi.c
> +++ b/drivers/spi/zynq_qspi.c
> @@ -20,15 +20,15 @@ DECLARE_GLOBAL_DATA_PTR;
>  #define ZYNQ_QSPI_CR_MSA_MASK		BIT(15)	/* Manual start enb
> */
>  #define ZYNQ_QSPI_CR_MCS_MASK		BIT(14)	/* Manual chip select
> */
>  #define ZYNQ_QSPI_CR_PCS_MASK		BIT(10)	/* Peri chip select */
> -#define ZYNQ_QSPI_CR_FW_MASK		(0x3 << 6)	/* FIFO width
> */
> -#define ZYNQ_QSPI_CR_SS_MASK		(0xF << 10)	/* Slave
> Select */
> -#define ZYNQ_QSPI_CR_BAUD_MASK		(0x7 << 3)	/*
> Baud rate div */
> +#define ZYNQ_QSPI_CR_FW_MASK		GENMASK(7, 6)	/*
> FIFO width */
> +#define ZYNQ_QSPI_CR_SS_MASK		GENMASK(13, 10)	/*
> Slave Select */
> +#define ZYNQ_QSPI_CR_BAUD_MASK		GENMASK(5, 3)
> 	/* Baud rate div */
>  #define ZYNQ_QSPI_CR_CPHA_MASK		BIT(2)	/* Clock phase */
>  #define ZYNQ_QSPI_CR_CPOL_MASK		BIT(1)	/* Clock polarity */
>  #define ZYNQ_QSPI_CR_MSTREN_MASK	BIT(0)	/* Mode select */
>  #define ZYNQ_QSPI_IXR_RXNEMPTY_MASK	BIT(4)	/*
> RX_FIFO_not_empty */
>  #define ZYNQ_QSPI_IXR_TXOW_MASK		BIT(2)	/*
> TX_FIFO_not_full */
> -#define ZYNQ_QSPI_IXR_ALL_MASK		0x7F		/* All IXR bits
> */
> +#define ZYNQ_QSPI_IXR_ALL_MASK		GENMASK(6, 0)	/* All
> IXR bits */
>  #define ZYNQ_QSPI_ENR_SPI_EN_MASK	BIT(0)	/* SPI Enable */
> 
>  /* zynq qspi Transmit Data Register */
> diff --git a/drivers/spi/zynq_spi.c b/drivers/spi/zynq_spi.c index
> 92e5712..9ede099 100644
> --- a/drivers/spi/zynq_spi.c
> +++ b/drivers/spi/zynq_spi.c
> @@ -22,14 +22,14 @@ DECLARE_GLOBAL_DATA_PTR;
>  /* zynq spi register bit masks ZYNQ_SPI_<REG>_<BIT>_MASK */
>  #define ZYNQ_SPI_CR_MSA_MASK		BIT(15)	/* Manual start enb
> */
>  #define ZYNQ_SPI_CR_MCS_MASK		BIT(14)	/* Manual chip select
> */
> -#define ZYNQ_SPI_CR_CS_MASK		(0xF << 10)	/* Chip select
> */
> -#define ZYNQ_SPI_CR_BAUD_MASK		(0x7 << 3)	/* Baud rate
> div */
> +#define ZYNQ_SPI_CR_CS_MASK		GENMASK(13, 10)	/*
> Chip select */
> +#define ZYNQ_SPI_CR_BAUD_MASK		GENMASK(5, 3)	/*
> Baud rate div */
>  #define ZYNQ_SPI_CR_CPHA_MASK		BIT(2)	/* Clock phase */
>  #define ZYNQ_SPI_CR_CPOL_MASK		BIT(1)	/* Clock polarity */
>  #define ZYNQ_SPI_CR_MSTREN_MASK		BIT(0)	/* Mode
> select */
>  #define ZYNQ_SPI_IXR_RXNEMPTY_MASK	BIT(4)	/*
> RX_FIFO_not_empty */
>  #define ZYNQ_SPI_IXR_TXOW_MASK		BIT(2)	/* TX_FIFO_not_full
> */
> -#define ZYNQ_SPI_IXR_ALL_MASK		0x7F		/* All IXR bits
> */
> +#define ZYNQ_SPI_IXR_ALL_MASK		GENMASK(6, 0)	/* All
> IXR bits */
>  #define ZYNQ_SPI_ENR_SPI_EN_MASK	BIT(0)	/* SPI Enable */
> 
>  #define ZYNQ_SPI_CR_BAUD_MAX		8	/* Baud rate divisor
> max val */
> --
> 1.9.1