[U-Boot] [PATCH v5 14/23] spi: ti_qspi: Use BIT macro
Vignesh R
vigneshr at ti.com
Mon Oct 26 11:59:43 CET 2015
On 10/24/2015 09:09 AM, Jagan Teki wrote:
> Replace numerical bit shift with BIT macro
> in ti_qspi
>
> :%s/(1 << nr)/BIT(nr)/g
> where nr = 0, 1, 2 .... 31
>
> Cc: Vignesh R <vigneshr at ti.com>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> Signed-off-by: Jagan Teki <jteki at openedev.com>
> ---
Acked-by: Vignesh R <vigneshr at ti.com>
> drivers/spi/ti_qspi.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/spi/ti_qspi.c b/drivers/spi/ti_qspi.c
> index bd63db8..ecd9d78 100644
> --- a/drivers/spi/ti_qspi.c
> +++ b/drivers/spi/ti_qspi.c
> @@ -20,13 +20,13 @@
> #define QSPI_TIMEOUT 2000000
> #define QSPI_FCLK 192000000
> /* clock control */
> -#define QSPI_CLK_EN (1 << 31)
> +#define QSPI_CLK_EN BIT(31)
> #define QSPI_CLK_DIV_MAX 0xffff
> /* command */
> #define QSPI_EN_CS(n) (n << 28)
> #define QSPI_WLEN(n) ((n-1) << 19)
> -#define QSPI_3_PIN (1 << 18)
> -#define QSPI_RD_SNGL (1 << 16)
> +#define QSPI_3_PIN BIT(18)
> +#define QSPI_RD_SNGL BIT(16)
> #define QSPI_WR_SNGL (2 << 16)
> #define QSPI_INVAL (4 << 16)
> #define QSPI_RD_QUAD (7 << 16)
> @@ -36,8 +36,8 @@
> #define QSPI_CSPOL(n) (1 << (1 + n*8))
> #define QSPI_CKPOL(n) (1 << (n*8))
> /* status */
> -#define QSPI_WC (1 << 1)
> -#define QSPI_BUSY (1 << 0)
> +#define QSPI_WC BIT(1)
> +#define QSPI_BUSY BIT(0)
> #define QSPI_WC_BUSY (QSPI_WC | QSPI_BUSY)
> #define QSPI_XFER_DONE QSPI_WC
> #define MM_SWITCH 0x01
>
--
Regards
Vignesh
More information about the U-Boot
mailing list