[U-Boot] [PATCH v3] Tegra: DT: add device tree binding doc for QSPI
Stephen Warren
swarren at wwwdotorg.org
Mon Oct 26 22:04:11 CET 2015
On 10/26/2015 02:34 PM, Tom Warren wrote:
> This patch adds the device tree binding doc for the Tegra
> QSPI controller on Tegra210.
> diff --git a/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt b/Documentation/devicetree/bindings/spi/nvidia,tegra210-qspi.txt
> +- clock-names : Must include the following entries:
> + - qspi
> +- resets : Must contain an entry for each entry in reset-names.
> + See ../reset/reset.txt for details.
> +- reset-names : Must include the following entries:
> + - qspi
> +- clocks : Must contain an entry for each entry in clock-names.
> + See ../clocks/clock-bindings.txt for details.
Let's keep clocks and clock-names next to each-other in the doc. I don't
know why they aren't in the eixsting Tegra SPI doc.
With this issue fixed, this patch looks good to me.
Note: I don't see the devicetree mailing list in the CC list. You should
probably replace the U-Boot mailing list with it.
> +Optional properties:
> +- dmas : Must contain an entry for each entry in clock-names.
> + See ../dma/dma.txt for details.
> +- dma-names : Must include the following entries:
> + - rx
> + - tx
Eventually, we should have a property that describes the SPI bus width
(x1, x2, x4 I assume). However, we can assume that unless otherwise
specified, the width is x1, and add a property to specify the width
later as/when we need it if you want.
More information about the U-Boot
mailing list