[U-Boot] [PATCH v2 00/28] dm: input: Move keyboard drivers to driver model

[Bin Meng]

Hi Simon,

On Tue, Oct 27, 2015 at 2:40 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Simon,
>
> On Mon, Oct 19, 2015 at 11:17 AM, Simon Glass <sjg at chromium.org> wrote:
>> This series adds a new uclass for keyboards and converts some drivers
>> over to use it.
>>
>> This series includes some work to remove code duplication in the keyboard
>> drivers by updating them to use the input library (input.c). This unifies
>> the keycode decoding logic in one place. In order to do this some
>> enhancements are needed to the input library and these are also included.
>>
>> The cros_ec and tegra_kbc drivers are converted to use driver model.
>>
>> The i8042 driver is converted also, after various tidy-ups. The driver has
>> some strange interactions with the cfb_console driver. This is removed in
>> this series which is possible because the only user is x86. Some i8042
>> features have been dropped (the only deliberate one is the flashing cursor
>> which does not seem to be used by any board).
>>
>> Also the i8042 driver currently has its own keycode-decoding logic. This
>> series removes it in favour of the input library. Therefore testing of this
>> new driver would be appreciated. So far I have only been able to test on
>> link, which does not have a full keyboard. Also, while German keyboard
>> support is implemented, I am unable to test that either.
>>
>> These changes can be considered the first step towards moving stdio to
>> driver model. For that to be useful we need to convert LCD and video also.
>>
>> Note: This series is missing the code to call the update_leds() method when
>> the LEDs change. This needs to be added to keyboard_tstc() and
>> keyboard_getc(). If someone is able to test this I can send a patch for that
>> also.
>
> With the v2 patch, the i8042 keyboard works on Intel Crown Bay.
> Besides the LEDs changes, I found the 'Caps Lock' and 'Num Lock' does
> not work. Is this related to missing update_leds()?

To be more specific, the symptom is:

After pressing 'Caps Lock', the 'Caps Lock' LED does not light up.
Pressing 'A' shows 'a' on the U-Boot serial console. After pressing
'Num Lock', the 'Num Lock' LED does not light up. Pressing any of the
the digit numbers (0-9) buttons on the numeric keypad can show the
numbers on the U-Boot serial console. I believe the correct behavior
is that when 'Num Lock' is not lighted, pressing (0-9) should return
nothing.

>
>>
>> This series is available at u-boot-dm branch input-working.
>>
>
> [snip]
>

Regards,
Bin