[U-Boot] [PATCH 2/3] vexpress64: remove #error

Linus Walleij linus.walleij at linaro.org
Tue Oct 27 12:36:59 CET 2015


On Wed, Oct 21, 2015 at 11:54 AM, Ryan Harkin <ryan.harkin at linaro.org> wrote:

> This patch allows vexpress64 targets to be compiled when
> CONFIG_SYS_FLASH_CFI is enabled.

I can't see what this has to do with enabling CFI?

> I considered using #warning instead of #error, but this just clutters up
> the build output and hides real warnings.
>
> Without this patch, you see errors during compilation like this:
>
> include/configs/vexpress_aemv8a.h:42:2: error: #error "Unknown board
> variant"
>  #error "Unknown board variant"

The #error is there because noone could answer the question I
posed: what AEMv8 boards are there that are neither FVP nor
Juno?

So what board variant are you compiling for here? I suspect a
non-upstream thingofabob? Maybe there is a better way to cater
for that than this magic catch-all?

Yours,
Linus Walleij


More information about the U-Boot mailing list