[U-Boot] [PATCH] spi: altera_spi: Minor cleanup

Thomas Chou thomas at wytron.com.tw
Wed Oct 28 08:14:56 CET 2015


Hi Jagan,

On 10/28/2015 01:47 AM, Jagan Teki wrote:
> - Moved macro definitions to top
> - Give tab space to CONFIG_ALTERA_SPI_IDLE_VAL value
> - Re-arrange header includes to ascending order
>
> Cc: Thomas Chou <thomas at wytron.com.tw>
> Signed-off-by: Jagan Teki <jteki at openedev.com>
> ---
>   drivers/spi/altera_spi.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>

Acked-by: Thomas Chou <thomas at wytron.com.tw>

Thanks a lot.

Best regards,
Thomas Chou

> diff --git a/drivers/spi/altera_spi.c b/drivers/spi/altera_spi.c
> index 3dbcfaa..e49949b 100644
> --- a/drivers/spi/altera_spi.c
> +++ b/drivers/spi/altera_spi.c
> @@ -11,14 +11,17 @@
>   #include <dm.h>
>   #include <errno.h>
>   #include <malloc.h>
> -#include <spi.h>
>   #include <fdtdec.h>
> +#include <spi.h>
>   #include <asm/io.h>
>
>   DECLARE_GLOBAL_DATA_PTR;
>
> +#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
> +#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
> +
>   #ifndef CONFIG_ALTERA_SPI_IDLE_VAL
> -#define CONFIG_ALTERA_SPI_IDLE_VAL 0xff
> +#define CONFIG_ALTERA_SPI_IDLE_VAL	0xff
>   #endif
>
>   struct altera_spi_regs {
> @@ -38,9 +41,6 @@ struct altera_spi_priv {
>   	struct altera_spi_regs *regs;
>   };
>
> -#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
> -#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
> -
>   static void spi_cs_activate(struct udevice *dev, uint cs)
>   {
>   	struct udevice *bus = dev->parent;
>


More information about the U-Boot mailing list