[U-Boot] [PATCH 3/3] vexpress64: store env in flash

[Ryan Harkin]

On 28 October 2015 at 15:10, Linus Walleij <linus.walleij at linaro.org> wrote:
> On Wed, Oct 28, 2015 at 4:07 PM, Ryan Harkin <ryan.harkin at linaro.org> wrote:
>> On 27 October 2015 at 21:39, Linus Walleij <linus.walleij at linaro.org> wrote:
>>> On Tue, Oct 27, 2015 at 1:49 PM, Ryan Harkin <ryan.harkin at linaro.org> wrote:
>>>
>>>> Either way, AFAIK, the existing CFI code does not handle AFS support.
>>>> I think the CFI code would need extending to write the footer if we
>>>> wanted the afs command to show the config in another way.  Could that
>>>> be what Peter Pearse did?
>>>
>>> Uh, I'd have to dig up the code ... actually that's a very good question.
>>>
>>
>> In the meantime, are you happy with my two patches?  One to remove the
>> #error lines and this one?
>
> This one:
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
> The other one I need to look at again, I'm not sure I understand
> it or why it's needed....

Yeah, have a look again.  I hoped my last reply explained that the
#error stuff happens when we include envcrc.c in the build.  It's
nothing to do with Juno r0/1/2 or FVP.

For reasons I don't understand, envcrc.c includes config.h which
includes vexpress64_aemv8a.h without the board #defines set at all, no
matter which board you are.  So the #error gets hit no matter if
you're building for FVP or Juno.

> was there a v2 coming?

Yes.