[U-Boot] [PATCH] nios2: add 10m50 devboard support

Marek Vasut marex at denx.de
Thu Oct 29 14:16:52 CET 2015


On Thursday, October 29, 2015 at 06:34:55 AM, Thomas Chou wrote:
> Hi Marek,
> 
> On 10/29/2015 07:45 AM, Marek Vasut wrote:
> >> +# CONFIG_CMD_SETEXPR is not set
> > 
> > Please keep setexpr, it's really useful.
> 
> OK, I will keep it.
> 
> >> +/*
> >> + * MII/PHY
> >> + */
> >> +#define CONFIG_CMD_MII			1
> >> +#define CONFIG_PHY_GIGE			1
> >> +#define CONFIG_SYS_FAULT_ECHO_LINK_DOWN	1
> >> +#define CONFIG_PHY_MARVELL		1
> > 
> > Are you sure all these macros must have a value (1) ? I doubt it.
> 
> Oops, these '1' should be removed.
> 
> I will resend this patch after I finish the altera quadspi and altera
> tse msgdma update. Thank you.

Thanks!

Best regards,
Marek Vasut


More information about the U-Boot mailing list