[U-Boot] [PATCH 1/8] serial: altera_jtag_uart: use BIT macro
Jagan Teki
jteki at openedev.com
Fri Oct 30 09:07:12 CET 2015
On 30 October 2015 at 12:48, Thomas Chou <thomas at wytron.com.tw> wrote:
> Replace numerical bit shift with BIT macro
> in altera_jtag_uart
>
> :%s/(1 << nr)/BIT(nr)/g
> where nr = 0, 1, 2 .... 31
>
> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
> ---
Reviewed-by: Jagan Teki <jteki at openedev.com>
> drivers/serial/altera_jtag_uart.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/serial/altera_jtag_uart.c b/drivers/serial/altera_jtag_uart.c
> index 39d4a4e..0aa741c 100644
> --- a/drivers/serial/altera_jtag_uart.c
> +++ b/drivers/serial/altera_jtag_uart.c
> @@ -22,11 +22,11 @@ struct altera_jtaguart_platdata {
> };
>
> /* data register */
> -#define ALTERA_JTAG_RVALID (1<<15) /* Read valid */
> +#define ALTERA_JTAG_RVALID BIT(15) /* Read valid */
>
> /* control register */
> -#define ALTERA_JTAG_AC (1 << 10) /* activity indicator */
> -#define ALTERA_JTAG_RRDY (1 << 12) /* read available */
> +#define ALTERA_JTAG_AC BIT(10) /* activity indicator */
> +#define ALTERA_JTAG_RRDY BIT(12) /* read available */
> #define ALTERA_JTAG_WSPACE(d) ((d)>>16) /* Write space avail */
> /* Write fifo size. FIXME: this should be extracted with sopc2dts */
> #define ALTERA_JTAG_WRITE_DEPTH 64
> --
> 2.5.0
thanks!
--
Jagan | openedev.
More information about the U-Boot
mailing list