[U-Boot] [PATCH 5/8] timer: altera_timer: use BIT macro

Jagan Teki jteki at openedev.com
Fri Oct 30 09:13:08 CET 2015


On 30 October 2015 at 12:48, Thomas Chou <thomas at wytron.com.tw> wrote:
> Replace numerical bit shift with BIT macro
> in altera_timer
>
> :%s/(1 << nr)/BIT(nr)/g
> where nr = 0, 1, 2 .... 31
>
> Signed-off-by: Thomas Chou <thomas at wytron.com.tw>
> ---

Reviewed-by: Jagan Teki <jteki at openedev.com>

>  drivers/timer/altera_timer.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/timer/altera_timer.c b/drivers/timer/altera_timer.c
> index 2ef9ad6..288357c 100644
> --- a/drivers/timer/altera_timer.c
> +++ b/drivers/timer/altera_timer.c
> @@ -31,9 +31,9 @@ struct altera_timer_platdata {
>  };
>
>  /* control register */
> -#define ALTERA_TIMER_CONT      (1 << 1)        /* Continuous mode */
> -#define ALTERA_TIMER_START     (1 << 2)        /* Start timer */
> -#define ALTERA_TIMER_STOP      (1 << 3)        /* Stop timer */
> +#define ALTERA_TIMER_CONT      BIT(1)  /* Continuous mode */
> +#define ALTERA_TIMER_START     BIT(2)  /* Start timer */
> +#define ALTERA_TIMER_STOP      BIT(3)  /* Stop timer */
>
>  static int altera_timer_get_count(struct udevice *dev, unsigned long *count)
>  {
> --
> 2.5.0

thanks!
-- 
Jagan | openedev.


More information about the U-Boot mailing list