[U-Boot] [PATCH v4 16/16] spi: Add SPI NOR protection mechanism

Fabio Estevam festevam at gmail.com
Fri Oct 30 17:51:31 CET 2015


Hi Jagan,

On Fri, Oct 30, 2015 at 2:28 PM, Jagan Teki <jteki at openedev.com> wrote:

>> +static int do_spi_protect(int argc, char * const argv[])
>> +{
>> +       int ret = 0;
>> +       loff_t start, len;
>> +       bool prot = false;
>> +
>> +       if (argc != 4)
>> +               return -1;
>> +
>> +       if (!str2off(argv[2], &start)) {
>> +               puts("start sector is not a valid number\n");
>> +               return 1;
>> +       }
>> +
>> +       if (!str2off(argv[3], &len)) {
>> +               puts("len is not a valid number\n");
>> +               return 1;
>> +       }
>> +
>> +       if (strcmp(argv[1], "lock") == 0)
>> +               prot = true;
>> +       else if (strcmp(argv[1], "unlock") == 0)
>> +               prot = false;
>> +       else
>
> Don't we have is_locked command from user? may be we can all this one as well.

Sorry, I did not understand the suggestion here.

Looks like you are happy with patches 1 to 15 of this series.

Could you please apply patches 1 to 15 and then I rework only this last one?


More information about the U-Boot mailing list