[U-Boot] [PATCH 07/13] drivers: spi: ti_qspi: convert driver to adopt device driver model

Mugunthan V N mugunthanvnm at ti.com
Sat Oct 31 12:46:14 CET 2015


On Thursday 29 October 2015 10:48 PM, Simon Glass wrote:
>> +       if (flash_num == 0) {
>> > +               debug("Error: Missing flashes!\n");
>> > +               return -ENODEV;
>> > +       }
> It looks like flash_num is only used for the debug message. Why not
> just drop this? The driver should not be scanning the device tree - it
> should be able to look at the number of child devices instead.
> 

Hmmm, will fix in v2

Regards
Mugunthan V N


More information about the U-Boot mailing list