[U-Boot] [PATCH] pfuze: Fix unsigned variable for less-than-zero comparison
Peng Fan
van.freenix at gmail.com
Mon Jan 4 08:26:30 CET 2016
From: "Ye.Li" <B37916 at freescale.com>
According to the Coverity result, a unsigned int variable is used fo less-
than-zero comparison, the result is never true. Need to fix the variable
type to signed int.
Signed-off-by: Ye.Li <B37916 at freescale.com>
Signed-off-by: Peng Fan <peng.fan at nxp.com>
Cc: Przemyslaw Marczak <p.marczak at samsung.com>
Cc: Stefano Babic <sbabic at denx.de>
---
board/freescale/common/pfuze.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/board/freescale/common/pfuze.c b/board/freescale/common/pfuze.c
index 783c46d..69afa83 100644
--- a/board/freescale/common/pfuze.c
+++ b/board/freescale/common/pfuze.c
@@ -13,7 +13,8 @@
int pfuze_mode_init(struct pmic *p, u32 mode)
{
unsigned char offset, i, switch_num;
- u32 id, ret;
+ u32 id;
+ int ret;
pmic_reg_read(p, PFUZE100_DEVICEID, &id);
id = id & 0xf;
--
2.6.2
More information about the U-Boot
mailing list