[U-Boot] Driver model test breakages

Wed Jan 6 01:24:41 CET 2016

Hi Jagan,

On 3 January 2016 at 23:09, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Jagan,
>
> On Mon, Jan 4, 2016 at 1:12 PM, Jagan Teki <jteki at openedev.com> wrote:
> > Hi Simon,
> >
> > On 4 January 2016 at 01:22, Simon Glass <sjg at chromium.org> wrote:
> >> Hi Jagan,
> >>
> >> On 22 December 2015 at 12:39, Joe Hershberger <joe.hershberger at gmail.com> wrote:
> >>> Hi Simon,
> >>>
> >>> On Tue, Dec 22, 2015 at 1:14 PM, Joe Hershberger
> >>> <joe.hershberger at gmail.com> wrote:
> >>>> Hi Simon,
> >>>>
> >>>> On Mon, Dec 21, 2015 at 9:17 PM, Joe Hershberger
> >>>> <joe.hershberger at gmail.com> wrote:
> >>>>> Hi Bin and Simon,
> >>>>>
> >>>>> On Mon, Dec 21, 2015 at 9:08 PM, Joe Hershberger
> >>>>> <joe.hershberger at gmail.com> wrote:
> >>>>>> Hi Bin,
> >>>>>>
> >>>>>> On Mon, Dec 21, 2015 at 9:00 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> >>>>>>> Hi Joe,
> >>>>>>>
> >>>>>>> On Tue, Dec 22, 2015 at 10:39 AM, Joe Hershberger
> >>>>>>> <joe.hershberger at gmail.com> wrote:
> >>>>>>>> On Mon, Dec 21, 2015 at 8:36 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> >>>>>>>>> Hi Joe,
> >>>>>>>>>
> >>>>>>>>> On Tue, Dec 22, 2015 at 10:32 AM, Joe Hershberger
> >>>>>>>>> <joe.hershberger at gmail.com> wrote:
> >>>>>>>>>> Hi Bin,
> >>>>>>>>>>
> >>>>>>>>>> On Mon, Dec 21, 2015 at 8:12 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> >>>>>>>>>>> Hi Joe, Simon,
> >>>>>>>>>>>
> >>>>>>>>>>> On Tue, Dec 22, 2015 at 6:46 AM, Joe Hershberger
> >>>>>>>>>>> <joe.hershberger at gmail.com> wrote:
> >>>>>>>>>>>> Hi Simon and Bin
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Thu, Dec 10, 2015 at 8:05 PM, Simon Glass <sjg at chromium.org> wrote:
> >>>>>>>>>>>>> Hi,
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> The following three commits causes breakages in the driver model tests:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> 4efad20a      sf: Update status reg check in spi_flash_cmd_wait_ready
> >>>>>>>>>>>>> 45b47734     net/arp: account for ARP delay, avoid duplicate packets on timeout
> >>>>>>>>>>>>> 9961a0b6    sandbox: add a sandbox timer and basic test
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Can you please take a look? You can run them with ./test/dm/test-dm.sh
> >>>>>>>>>>>>
> >>>>>>>>>>>> It appears that ac1d313 (net: eth: Check return value in various
> >>>>>>>>>>>> places) breaks the eth_rotate test.
> >>>>>>>>>>>>
> >>>>>>>>>>>> Looking into it. Bin, do you have any ideas?
> >>>>>>>>>>>
> >>>>>>>>>>> I will look into this.
> >>>>>>>>>>>
> >>>>>>>>>>> BTW: I applied the following two patches [1][2] to the tree based on
> >>>>>>>>>>> dm/master, and got a segmentation fault:
> >>>>>>>>>>>
> >>>>>>>>>>> Test: dm_test_usb_keyb
> >>>>>>>>>>> ./test/dm/test-dm.sh: line 14: 24902 Segmentation fault
> >>>>>>>>>>> ./sandbox/u-boot -d ./sandbox/arch/sandbox/dts/test.dtb -c "ut dm"
> >>>>>>>>>>>
> >>>>>>>>>>> [1] http://patchwork.ozlabs.org/patch/555597/
> >>>>>>>>>>> [2] http://patchwork.ozlabs.org/patch/559783/
> >>>>>>>>>>
> >>>>>>>>>> Interesting. I haven't tested on top of dm/master, but I tested it
> >>>>>>>>>> based on origin/master and the issue is resolved.
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Which issue is resolved? I just tested on top of origin/master with
> >>>>>>>>> the above two patches, still the same segmentation fault.
> >>>>>>>>
> >>>>>>>> The net_retry dm test hang that Simon reported.
> >>>>>>>>
> >>>>>>>
> >>>>>>> The segmentation fault happens after "Test: dm_test_usb_keyb". It
> >>>>>>> seems to be a new issue.
> >>>>>>
> >>>>>> I agree it's a new issue that was masked by the net_retry hang.
> >>>>>
> >>>>> It appears, not too surprisingly, that d77a7d8 (dm: test: usb:
> >>>>> sandbox: Add keyboard tests for sandbox) is the source of the seg
> >>>>> fault.
> >>>>>
> >>>>> Simon?
> >>>>
> >>>> In looking for the seg fault in the usb kbd test, I found that the
> >>>> udev ptr passed to usb uclass is garbage, so the usb_ops is null, so
> >>>> we crash. Do you have a quick explanation for how this emulated USB is
> >>>> supposed to work? I haven't looked at it before. I'll keep digging
> >>>> until you can provide some insight.
> >>>
> >>> Actually the controller passed in is OK and the driver ptr is OK, but
> >>> the ops ptr is NULL. Seems odd.
> >>
> >> Jagan, do you have any thoughts on the SPI flash crash with
> >> test/dm/test0dm,sh? It is still broken and the release is almost upon
> >> us. This means that SPI flash is not working correct at present.
> >
> > Sorry, that I couldn't find this mail as it moved some where.
> >
> > And I never ran these dm tests before tried now - please see below.
> >
> > Test: dm_test_rtc_set_get
> > Test: dm_test_spi_find
> > ../test/dm/spi.c:63, dm_test_spi_find(): -ENOENT ==
> > spi_get_bus_and_cs(busnum, cs, speed, mode, "spi_flash_std", "name",
> > &bus, &slave): Expected -2, got -22
> > Test: dm_test_spi_flash
> > ./test/dm/test-dm.sh: line 14: 14628 Segmentation fault      (core
> > dumped) ./sandbox/u-boot -d ./sandbox/arch/sandbox/dts/test.dtb -c "ut
> > dm"
> >
>
> Please ignore the 'Segmentation fault' issue. Simon got it fixed in
> other patches.

Please see u-boot-dm/master. There are also patches in this series
which I have not applied yet:

http://patchwork.ozlabs.org/patch/562195/

Also you can disable any tests you don't want by commenting out things
in the Makefile. Unfortunately you can't run the SPI tests by
themselves (with 'ut dm <testname>') unless you create the test file
manually.

Please let me know if you come up with a fix.

>
> > these are the issues? from you mail how come these issues related to
> >
> > 4efad20a      sf: Update status reg check in spi_flash_cmd_wait_ready
> >
>
> I believe Simon pinpointed this commit via 'git bisect'. You should be
> able to use 'git bisect' to get the same result.
>
> > Because this particular change is respective to spi_flash core and the
> > drivers/mtd/spi/sandbox is not using I suppose.
> >
> > Please let me know your inputs.
> >
> > thanks!
> > --

Regards,
Simon