[U-Boot] [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031

Qiang Zhao qiang.zhao at nxp.com
Wed Jan 6 07:19:51 CET 2016


On Tue, Jan 5, 2016 at 1:02 PM, Fabio Estevam <festevam at gmail.com> wrote:
> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: Wednesday, January 06, 2016 3:03 AM
> To: sbabic at denx.de
> Cc: joe.hershberger at ni.com; B45475 at freescale.com; yorksun at freescale.com;
> troy.kisky at boundarydevices.com; u-boot at lists.denx.de; Fabio Estevam
> <fabio.estevam at nxp.com>
> Subject: [PATCH v2 1/3] phy: atheros: Use ar8035_config for AR8031
> 
> From: Fabio Estevam <fabio.estevam at nxp.com>
> 
> Commit 08ad9b068afb88 (" ar8031: modify the config func of ar8031 to
> ar8021_config") selected 'ar8021_config' as the configuration function for
> AR8031.
> 
> The correct would be to use 'ar8035_config' instead as AR8031/AR8035 have
> the same programming model and even share the same phy driver in the linux
> kernel: drivers/net/phy/at803x.c.
> 
> Tested on a mx6qsabresd and wandboard, which now can work without any
> PHY setup code in the board files.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
> This is 2016.04 material.
> 
> Zhao Qiang, could you please test this on your platform?

Yes, have tested, it can work on my platform.

> 
> Changes since v1:
> - None
> 
>  drivers/net/phy/atheros.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/atheros.c b/drivers/net/phy/atheros.c index
> d509e30..ba57b1a 100644
> --- a/drivers/net/phy/atheros.c
> +++ b/drivers/net/phy/atheros.c
> @@ -51,7 +51,7 @@ static struct phy_driver AR8031_driver =  {
>  	.uid = 0x4dd074,
>  	.mask = 0xffffffef,
>  	.features = PHY_GBIT_FEATURES,
> -	.config = ar8021_config,
> +	.config = ar8035_config,
>  	.startup = genphy_startup,
>  	.shutdown = genphy_shutdown,
>  };
> --
> 1.9.1

Best Regards
Zhao Qiang


More information about the U-Boot mailing list