[U-Boot] [PATCH] cmd_pci: Check for VendorID earlier

Fabio Estevam festevam at gmail.com
Wed Jan 6 21:36:39 CET 2016


On Tue, Jan 5, 2016 at 9:58 PM, Fabio Estevam <festevam at gmail.com> wrote:
> Hi Bin,
>
> On Thu, Dec 31, 2015 at 1:20 PM, Fabio Estevam <festevam at gmail.com> wrote:
>
>> Do you mean like this for imx?
>>
>> --- a/drivers/pci/pcie_imx.c
>> +++ b/drivers/pci/pcie_imx.c
>> @@ -381,7 +381,7 @@ static int imx_pcie_read_config(struct pci_controller *hose,
>>         ret = imx_pcie_addr_valid(d);
>>         if (ret) {
>>                 *val = 0xffffffff;
>> -               return ret;
>> +               return 0;
>
> Thinking a bit more about this: shouldn't we fix imx_pcie_addr_valid() instead?
>
> I am not sure if the above change is the correct fix. At least I am
> not able to prepare a convincing commit log for it :-)

Ok, looked at the kernel PCI designware driver and will send a patch
series that fixes this issue by using the approach done in the kernel.


More information about the U-Boot mailing list