[U-Boot] [PATCH] spi: spi_flash: Fix the arguments of stm_is_locked_sr()

Jagan Teki jteki at openedev.com
Thu Jan 7 13:18:48 CET 2016


On 6 January 2016 at 05:54, Fabio Estevam <festevam at gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam at nxp.com>
>
> stm_is_locked_sr() takes the status register (SR) value as the last
> parameter, not the second.
>
> Based on a patch from Brian Norris for the linux kernel:
> http://git.infradead.org/linux-mtd.git/commitdiff/a32d5b726ff8cf32bf491522b0ac8ae2545a063e?hp=67b9bcd36906e12a15ffec19463afbbd6a41660e

This link seems too long

What about this?

http://git.infradead.org/linux-mtd.git/commit/a32d5b726ff8cf32bf491522b0ac8ae2545a063e

>
> Signed-off-by: Fabio Estevam <fabio.estevam at nxp.com>
> ---
>  drivers/mtd/spi/spi_flash.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c
> index 7ffa136..b7b7f00 100644
> --- a/drivers/mtd/spi/spi_flash.c
> +++ b/drivers/mtd/spi/spi_flash.c
> @@ -767,8 +767,8 @@ int stm_unlock(struct spi_flash *flash, u32 ofs, size_t len)
>                 return ret;
>
>         /* Cannot unlock; would unlock larger region than requested */
> -       if (stm_is_locked_sr(flash, status_old, ofs - flash->erase_size,
> -                            flash->erase_size))
> +       if (stm_is_locked_sr(flash, ofs - flash->erase_size, flash->erase_size,
> +                            status_old))
>                 return -EINVAL;
>         /*
>          * Need largest pow such that:
> --
> 1.9.1


-- 
Jagan.


More information about the U-Boot mailing list