[U-Boot] [PATCH] power: pmic.h: Drop include <spi.h>

[Tom Rini]

On Thu, Jan 07, 2016 at 08:01:29PM +0530, Jagan Teki wrote:
> On 6 January 2016 at 05:54, Simon Glass <sjg at chromium.org> wrote:
> > On 5 January 2016 at 01:14, Jagan Teki <jteki at openedev.com> wrote:
> >> include/power/pmic.h never used any generic spi code
> >> from include/spi.h, but this has been added in below commit.
> >> "dm: pmic: add implementation of driver model pmic uclass"
> >> (sha1: 4d9057e82be11a862db411c4867e859fe0d4ca2a)
> >>
> >> Adding functionalities in include/spi.h will trigger a build
> >> issue as this been added used in include/power/pmic.h
> >>
> >> Build issue on trats2 with adding BIT macro on spi.h:
> >> ----------------------------------------------------
> >>   CC      lib/asm-offsets.s
> >> In file included from include/power/pmic.h:15:0,
> >>                  from include/power/max77686_pmic.h:11,
> >>                  from include/configs/trats2.h:212,
> >>                  from include/config.h:5,
> >>                  from include/common.h:18,
> >>                  from lib/asm-offsets.c:15:
> >> include/spi.h: In function 'spi_w8r8':
> >> include/spi.h:327:2: warning: implicit declaration of function 'BIT' [-Wimplicit-function-declaration]
> >>
> >> Cc: Simon Glass <sjg at chromium.org>
> >> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> >> Reported-by: Tom Rini <trini at konsulko.com>
> >> Signed-off-by: Jagan Teki <jteki at openedev.com>
> >> ---
> >>  include/power/pmic.h | 1 -
> >>  1 file changed, 1 deletion(-)
> >
> > Acked-by: Simon Glass <sjg at chromium.org>
> >
> > I suppose we could do i2c.h also?
> 
> Tom, I'm taking this as part of u-boot-spi as I have two more fixes -
> all + previous PR will send it again, any concerns?

Yes, it's simply too close to the release to make that level of change.
I'll take the SPI PR with this applied after the release.  If there's
any critical bugfix only things please put them in a new PR.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160107/30cf5fb7/attachment.sig>