[U-Boot] [PATCH] pfuze: Fix unsigned variable for less-than-zero comparison
Stefano Babic
sbabic at denx.de
Thu Jan 7 17:49:27 CET 2016
On 04/01/2016 08:26, Peng Fan wrote:
> From: "Ye.Li" <B37916 at freescale.com>
>
> According to the Coverity result, a unsigned int variable is used fo less-
> than-zero comparison, the result is never true. Need to fix the variable
> type to signed int.
>
> Signed-off-by: Ye.Li <B37916 at freescale.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
> board/freescale/common/pfuze.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/freescale/common/pfuze.c b/board/freescale/common/pfuze.c
> index 783c46d..69afa83 100644
> --- a/board/freescale/common/pfuze.c
> +++ b/board/freescale/common/pfuze.c
> @@ -13,7 +13,8 @@
> int pfuze_mode_init(struct pmic *p, u32 mode)
> {
> unsigned char offset, i, switch_num;
> - u32 id, ret;
> + u32 id;
> + int ret;
>
> pmic_reg_read(p, PFUZE100_DEVICEID, &id);
> id = id & 0xf;
>
Applied (fix) to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list