[U-Boot] [PATCH] powerpc, mpc5xxx: fix missing bootflag init
Wolfgang Denk
wd at denx.de
Thu Jan 7 20:30:53 CET 2016
Dear York,
In message <AM4PR0401MB1732D7EBA1C64E62F3A403449AF50 at AM4PR0401MB1732.eurprd04.prod.outlook.com> you wrote:
>
> > So board_init_f gets a undefined bootflag,
> > currently the gd pointer address. Unfortunately
> > this address sets the GD_FLG_SKIP_RELOC bit,
> > so u-boot code gets not relocated and u-boot
> > does not boot ...
> >
> > Init bootflag with 0, and tqm5200 boots fine again.
...
> Applied to u-boot-mpc85x. Merged upstream.
Thanmks - but I think this needs a follow-up patch - Heiko is already
looking into that. On closer inspection it appears as if the whole
passing around of "bootflag" variables is just dead code - there is no
place anywhere in U-Boot that makes real use of this data. We should
remove all of the related code, which will make the code cleaner and
smaller - which might be especially welcome in a number of SPL
configurations.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quotation, n. The act of repeating erroneously the words of another.
The words erroneously repeated.
- Ambrose Bierce _The Devil's Dictionary_
More information about the U-Boot
mailing list