[U-Boot] [PATCH] usb: Define USB_MAX_STOR_DEV in only one place

Simon Glass sjg at chromium.org
Fri Jan 8 04:34:44 CET 2016


Hi Marek,

On 7 January 2016 at 15:50, Marek Vasut <marex at denx.de> wrote:
> On Thursday, January 07, 2016 at 11:16:08 PM, Simon Glass wrote:
>> We can define this in the header file and use it in usb_storage.c. There is
>> no need to define it twice. Remove the #define from usb_storage.c.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>
> I guess you build tested this properly, right ?

Yes. I was initially nervous that there might be a reason for the two
definitions but I cannot see what it might be. So I think this patch
is safe. Anyway I'll hold off applying it until early in the merge
window.

>
> Reviewed-by: Marek Vasut <marex at denx.de>
>
> Best regards,
> Marek Vasut

Regards,
Simon


More information about the U-Boot mailing list