[U-Boot] [PATCH 3/4] arm: mvebu: Add runtime boot-device detection

Stefan Roese sr at denx.de
Wed Jan 13 17:18:57 CET 2016


On 13.01.2016 17:12, Kevin Smith wrote:
> On 01/09/2016 03:07 AM, Stefan Roese wrote:
>> @@ -100,14 +100,24 @@
>>    #if defined(CONFIG_ARMADA_38X)
>>    /* SAR values for Armada 38x */
>>    #define CONFIG_SAR_REG		(MVEBU_REGISTER(0x18600))
>> +
>>    #define SAR_CPU_FREQ_OFFS	10
>>    #define SAR_CPU_FREQ_MASK	(0x1f << SAR_CPU_FREQ_OFFS)
>>    #define SAR_BOOT_DEVICE_OFFS	4
>>    #define SAR_BOOT_DEVICE_MASK	(0x1f << SAR_BOOT_DEVICE_OFFS)
>> +
>> +#define BOOT_DEV_SEL_OFFS	4
>> +#define BOOT_DEV_SEL_MASK	(0x1f << BOOT_DEV_SEL_OFFS)
>> +
> It is a little confusing that this is added incorrectly here, then
> corrected in the next patch ... could this just be added as 0x3f here?

Ah, right. I've fixed this define in the next patch:

arm: mvebu: Add runtime detection of UART (xmodem) boot-mode

Which is already waiting for upstreaming as well (once Luka picks it
up). I hope this is okay. Otherwise I would need to re-do those
patches again.

Thanks,
Stefan



More information about the U-Boot mailing list