[U-Boot] [PATCH] common: env_flags: fix loop condition when using env_flags_varaccess_mask

Simon Glass sjg at chromium.org
Wed Jan 13 21:09:43 CET 2016


On 12 January 2016 at 02:23, Peng Fan <van.freenix at gmail.com> wrote:
> From: Peng Fan <peng.fan at nxp.com>
>
> We should use ARRAY_SIZE, but not sizeof. The size of
> env_flags_varaccess_mask is 16bytes, but we only need 4 loops.
> If using 16 as the end condition, we may access memory that
> not belong to array env_flags_varaccess_mask.
>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: York Sun <yorksun at freescale.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Tom Rini <trini at konsulko.com>
> ---
>  common/env_flags.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list