[U-Boot] [PATCH] imx: mx6/7 define CONFIG_SYS_VSNPRINTF

Peng Fan van.freenix at gmail.com
Thu Jan 14 02:54:09 CET 2016


Hi Tom,

On Wed, Jan 13, 2016 at 02:57:00PM -0500, Tom Rini wrote:
>On Tue, Jan 12, 2016 at 05:45:24PM +0800, Peng Fan wrote:
>
>> From: Peng Fan <peng.fan at nxp.com>
>> 
>> Define CONFIG_SYS_VSNPRINTF to use snprintf. If not define
>> CONFIG_SYS_VSNPRINTF, snprintf is sprintf.
>> 
>> Report by Coverity:
>> pass string init_val of unknown size to sprintf
>> 
>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>> Cc: Peter Robinson <pbrobinson at gmail.com>
>> Cc: Fabio Estevam <fabio.estevam at freescale.com>
>> Cc: Adrian Alonso <aalonso at freescale.com>
>> Cc: Stefano Babic <sbabic at denx.de>
>
>I'm not sure how I feel about fixing this range of issues only for
>certain targets.  I need to do some global building here and see what
>happens.


With CONFIG_SYS_VSNPRINTF defined, image size may be bigger. So here,
I use #ifdef CONFIG_SPL_BUILD.

Ok, wait for your further comments on this.

Regards,
Peng.
>
>-- 
>Tom




More information about the U-Boot mailing list