[U-Boot] [PATCH 6/9] efi_loader: Add runtime services

Alexander Graf agraf at suse.de
Fri Jan 15 15:15:37 CET 2016



On 15.01.16 14:52, Leif Lindholm wrote:
> On Fri, Jan 15, 2016 at 01:26:42AM +0100, Alexander Graf wrote:
>> On 26.12.15 19:33, Leif Lindholm wrote:
>>>> +	.reset_system = (void *)&efi_unimplemented,
>>>
>>> "The ResetSystem() function does not return."
>>
>> Hrm, I think returning EFI_UNSUPPORTED is still better than while(1) {
>> }. With the return an OS at least has the chance to fix things up itself.
> 
> I'm not saying it isn't better, I'm saying it's not compliant - there
> is no valid return value. I would prefer simply having the pointer set
> to NULL.

Is a NULL function pointer valid here?


Alex


More information about the U-Boot mailing list