[U-Boot] [PATCH] drivers/power/regulator/max77686.c: Don't use switch() on bools

[Michael Trimarchi]

Hi

On Sun, Jan 17, 2016 at 3:44 AM, Tom Rini <trini at konsulko.com> wrote:
> With gcc-5.3 we get a warning for using switch() on a bool type.
> Rewrite these sections as if/else and update the one section that was
> using 1/0 instead of true/false.
>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Przemyslaw Marczak <p.marczak at samsung.com>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  drivers/power/regulator/max77686.c | 28 ++++++++--------------------
>  1 file changed, 8 insertions(+), 20 deletions(-)
>

I never seen subject that contains the path of a driver.

Michael

> diff --git a/drivers/power/regulator/max77686.c b/drivers/power/regulator/max77686.c
> index 71678b6..7479af7 100644
> --- a/drivers/power/regulator/max77686.c
> +++ b/drivers/power/regulator/max77686.c
> @@ -515,25 +515,19 @@ static int max77686_ldo_enable(struct udevice *dev, int op, bool *enable)
>
>                 switch (on_off) {
>                 case OPMODE_OFF:
> -                       *enable = 0;
> +                       *enable = false;
>                         break;
>                 case OPMODE_ON:
> -                       *enable = 1;
> +                       *enable = true;
>                         break;
>                 default:
>                         return -EINVAL;
>                 }
>         } else if (op == PMIC_OP_SET) {
> -               switch (*enable) {
> -               case 0:
> -                       on_off = OPMODE_OFF;
> -                       break;
> -               case 1:
> +               if (*enable)
>                         on_off = OPMODE_ON;
> -                       break;
> -               default:
> -                       return -EINVAL;
> -               }
> +               else
> +                       on_off = OPMODE_OFF;
>
>                 ret = max77686_ldo_mode(dev, op, &on_off);
>                 if (ret)
> @@ -651,16 +645,10 @@ static int max77686_buck_enable(struct udevice *dev, int op, bool *enable)
>                         return -EINVAL;
>                 }
>         } else if (op == PMIC_OP_SET) {
> -               switch (*enable) {
> -               case 0:
> -                       on_off = OPMODE_OFF;
> -                       break;
> -               case 1:
> +               if (*enable)
>                         on_off = OPMODE_ON;
> -                       break;
> -               default:
> -                       return -EINVAL;
> -               }
> +               else
> +                       on_off = OPMODE_OFF;
>
>                 ret = max77686_buck_mode(dev, op, &on_off);
>                 if (ret)
> --
> 2.7.0.rc3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |