[U-Boot] [PATCH 02/23] dm: video: Flush the cache after a puts()

[Tom Warren]

Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Monday, January 18, 2016 7:03 PM
> To: Tom Warren <TWarren at nvidia.com>
> Cc: U-Boot Mailing List <u-boot at lists.denx.de>; Stephen Warren
> <swarren at wwwdotorg.org>; Stephen Warren <swarren at nvidia.com>; Marek
> Vasut <marek.vasut at gmail.com>; Anatolij Gustschin <agust at denx.de>; Pavel
> Herrmann <morpheus.ibis at gmail.com>
> Subject: Re: [PATCH 02/23] dm: video: Flush the cache after a puts()
> 
> Hi Tom,
> 
> On 18 January 2016 at 15:29, Tom Warren <TWarren at nvidia.com> wrote:
> > Simon,
> >
> >> -----Original Message-----
> >> From: Simon Glass [mailto:sjg at google.com] On Behalf Of Simon Glass
> >> Sent: Thursday, January 14, 2016 11:28 AM
> >> To: U-Boot Mailing List <u-boot at lists.denx.de>
> >> Cc: Tom Warren <TWarren at nvidia.com>; Stephen Warren
> >> <swarren at wwwdotorg.org>; Stephen Warren <swarren at nvidia.com>;
> Simon
> >> Glass <sjg at chromium.org>; Marek Vasut <marek.vasut at gmail.com>;
> >> Anatolij Gustschin <agust at denx.de>; Pavel Herrmann
> >> <morpheus.ibis at gmail.com>
> >> Subject: [PATCH 02/23] dm: video: Flush the cache after a puts()
> >>
> >> This helps keep the display consistent. puts() is used when printing
> >> the prompt, so is a useful way to make sure the current display contents is
> visible.
> >>
> >> Signed-off-by: Simon Glass <sjg at chromium.org>
> >> ---
> > This doesn't apply to TOT u-boot-tegra/master (just rebased against TOT u-
> boot/master). Vidconsole-uclass.c is missing:
> >
> > Applying: dm: video: Flush the cache after a puts()
> > error: drivers/video/vidconsole-uclass.c: does not exist in index
> > Patch failed at 0002 dm: video: Flush the cache after a puts() The
> > copy of the patch that failed is found in:
> >    /home/tom/denx/uboot-tegra/.git/rebase-apply/patch
> >
> 
> Yes this depends on the driver model series - see u-boot-dm/rkf-working for the
> source tree. I've got a few comments on the uclass now so I'll send v2 at some
> point and hopefully apply it soon after that.

OK. But you've assigned these to me in Patchwork (or I've been automatically designated as the Delegate), which makes me think I need to at least try and apply them to u-boot-tegra.
Same with the 23-part display driver-model changes, which don't apply either.

If these are going to go in thru the DM repo, please reassign to yourself. If they're eventually going to apply cleanly to u-boot-tegra, leave them delegated to me and let me know when V2 is ready.

Thanks,

Tom
> 
> > Tom
> >
--
nvpublic
> >
> >>
> >>  drivers/video/vidconsole-uclass.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/video/vidconsole-uclass.c
> >> b/drivers/video/vidconsole-uclass.c
> >> index 706a189..a4c919e 100644
> >> --- a/drivers/video/vidconsole-uclass.c
> >> +++ b/drivers/video/vidconsole-uclass.c
> >> @@ -139,6 +139,7 @@ static void vidconsole_puts(struct stdio_dev
> >> *sdev, const char *s)
> >>
> >>       while (*s)
> >>               vidconsole_put_char(dev, *s++);
> >> +     video_sync(dev->parent);
> >>  }
> >>
> >>  /* Set up the number of rows and colours (rotated drivers override
> >> this) */
> >> --
> >> 2.6.0.rc2.230.g3dd15c0
> >
> 
> Regards,
> Simon