[U-Boot] [Patch V4 1/4] spi: fsl_qspi: fix compile warning for 64-bit platform

york sun york.sun at nxp.com
Tue Jan 19 19:41:41 CET 2016


On 01/10/2016 06:14 PM, Gong Qianyu wrote:
> From: Gong Qianyu <Qianyu.Gong at freescale.com>
> 
> This patch fixes the following compile warning:
> drivers/spi/fsl_qspi.c: In function 'fsl_qspi_probe':
> drivers/spi/fsl_qspi.c:937:15:
>   warning: cast to pointer from integer of different size
> 					 [-Wint-to-pointer-cast]
>   priv->regs = (struct fsl_qspi_regs *)plat->reg_base;
>                ^
> Just make the cast explict.
> 
> Signed-off-by: Gong Qianyu <Qianyu.Gong at freescale.com>
> ---
> V4:
>  - Revise the commit message.
> V2-V3:
>  - No change.
> 
>  drivers/spi/fsl_qspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
> index feec3e8..9f23c10 100644
> --- a/drivers/spi/fsl_qspi.c
> +++ b/drivers/spi/fsl_qspi.c
> @@ -936,7 +936,7 @@ static int fsl_qspi_probe(struct udevice *bus)
>  
>  	dm_spi_bus->max_hz = plat->speed_hz;
>  
> -	priv->regs = (struct fsl_qspi_regs *)plat->reg_base;

The reg_base is u32. Is it always correct on 64-bit SoC?

> +	priv->regs = (struct fsl_qspi_regs *)(unsigned long)plat->reg_base;

How about (struct fsl_qspi_regs *)(uintptr_t)plat->reg_base?

York




More information about the U-Boot mailing list