[U-Boot] [PATCH] fsl_qspi: fix address mask issue

Peng Fan van.freenix at gmail.com
Wed Jan 20 02:13:59 CET 2016


On Tue, Jan 19, 2016 at 09:07:18PM +0800, Ye Li wrote:
>The OFFSET_BITS_MASK should mask bit from 0-23.
>By using GENMASK(24, 0), when using the fast read common (0xb), a
>invalid sf_addr 0x1000000 is produced by swab32(txbuf) & OFFSET_BITS_MASK.
>
>Signed-off-by: Ye Li <ye.li at nxp.com>
>---
> drivers/spi/fsl_qspi.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c
>index feec3e8..542b6cf 100644
>--- a/drivers/spi/fsl_qspi.c
>+++ b/drivers/spi/fsl_qspi.c
>@@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR;
> #define TX_BUFFER_SIZE		0x40
> #endif
> 
>-#define OFFSET_BITS_MASK	GENMASK(24, 0)
>+#define OFFSET_BITS_MASK	GENMASK(23, 0)
> 
> #define FLASH_STATUS_WEL	0x02

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> 
>-- 
>1.7.4.1
>
>_______________________________________________
>U-Boot mailing list
>U-Boot at lists.denx.de
>http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list