[U-Boot] [PATCH v2 3/4] x86: config option for loading ACPI table from QEMU

[Miao Yan]

Hi Bin,

2016-01-20 17:18 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
> Hi Miao,
>
> On Wed, Jan 20, 2016 at 5:15 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>> Hi Bin,
>>
>> 2016-01-20 16:46 GMT+08:00 Bin Meng <bmeng.cn at gmail.com>:
>>> On Wed, Jan 20, 2016 at 12:24 PM, Miao Yan <yanmiaobest at gmail.com> wrote:
>>>> This patch adds a config option for loading ACPI table from QEMU. When enabled,
>>>> U-Boot won't generate ACPI tables, but use those provided by QEMU.
>>>>
>>>> Signed-off-by: Miao Yan <yanmiaobest at gmail.com>
>>>> ---
>>>>  arch/x86/Kconfig           | 9 +++++++++
>>>>  arch/x86/cpu/qemu/Makefile | 2 ++
>>>>  arch/x86/lib/Makefile      | 2 ++
>>>>  3 files changed, 13 insertions(+)
>>>>
>>>
>>> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>>> Tested-by: Bin Meng <bmeng.cn at gmail.com>
>>>
>>> But please see one nits below:
>>>
>>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>>>> index f07567c..26c8d83 100644
>>>> --- a/arch/x86/Kconfig
>>>> +++ b/arch/x86/Kconfig
>>>> @@ -358,6 +358,15 @@ config GENERATE_ACPI_TABLE
>>>>           by the operating system. It defines platform-independent interfaces
>>>>           for configuration and power management monitoring.
>>>>
>>>> +config QEMU_ACPI_TABLE
>>>> +       bool "load ACPI table from QEMU fw_cfg interface"
>>>
>>> nits: load -> Load
>>>
>>> I can fix this when applying.
>>
>> Thanks, I just found this patch breaks git bisect, I'll submit v3 to
>> fix this as well as the typo.
>>
>>
>
> Uh, I've tested building your patches via buildman, no errors. What do you see?

If you enable CONFIG_GENERATE_ACPI_TABLE and QEMU_ACPI_TABLE, you'll see:

arch/x86/lib/built-in.o: In function `write_tables':
/home/myan/work/u-boot-x86/arch/x86/lib/tables.c:57: undefined
reference to `write_acpi_tables'
make: *** [u-boot] Error

Because write_acpi_tables() are defined in [PATCH 0/4]. With default
config you won't see it. Is this OK ?


>
>>>
>>>> +       depends on GENERATE_ACPI_TABLE && QEMU
>>>> +       default y
>>>> +       help
>>>> +         By default, U-Boot generates its own ACPI tables. This option, if
>>>> +         enabled, disables U-Boot's version and loads ACPI tables generated
>>>> +         by QEMU.
>>>> +
>>>
>>> [snip]
>>>
>
> Regards,
> Bin