[U-Boot] arm, ubifs: fix gcc5.x compiler warning

Tom Rini trini at konsulko.com
Wed Jan 20 22:00:27 CET 2016


On Mon, Nov 30, 2015 at 08:47:42AM +0100, Heiko Schocher wrote:

> compiling U-Boot for openrd_base_defconfig with
> gcc 5.x shows the following warning:
> 
>   CC      fs/ubifs/super.o
> In file included from fs/ubifs/ubifs.h:35:0,
>                  from fs/ubifs/super.c:37:
> fs/ubifs/super.c: In function 'atomic_inc':
> ./arch/arm/include/asm/atomic.h:55:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
>   local_irq_save(flags);
>   ^
> fs/ubifs/super.c: In function 'atomic_dec':
> ./arch/arm/include/asm/atomic.h:64:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
>   local_irq_save(flags);
>   ^
>   CC      fs/ubifs/sb.o
> [...]
>   CC      fs/ubifs/lpt.o
> In file included from include/linux/bitops.h:123:0,
>                  from include/common.h:20,
>                  from include/ubi_uboot.h:17,
>                  from fs/ubifs/ubifs.h:37,
>                  from fs/ubifs/lpt.c:35:
> fs/ubifs/lpt.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
>   local_irq_save(flags);
>   ^
>   CC      fs/ubifs/lpt_commit.o
> In file included from include/linux/bitops.h:123:0,
>                  from include/common.h:20,
>                  from include/ubi_uboot.h:17,
>                  from fs/ubifs/ubifs.h:37,
>                  from fs/ubifs/lpt_commit.c:26:
> fs/ubifs/lpt_commit.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
>   local_irq_save(flags);
>   ^
>   CC      fs/ubifs/scan.o
>   CC      fs/ubifs/lprops.o
>   CC      fs/ubifs/tnc.o
> In file included from include/linux/bitops.h:123:0,
>                  from include/common.h:20,
>                  from include/ubi_uboot.h:17,
>                  from fs/ubifs/ubifs.h:37,
>                  from fs/ubifs/tnc.c:30:
> fs/ubifs/tnc.c: In function 'test_and_set_bit':
> ./arch/arm/include/asm/bitops.h:57:2: warning: 'flags' is used uninitialized in this function [-Wuninitialized]
>   local_irq_save(flags);
>   ^
>   CC      fs/ubifs/tnc_misc.o
> 
> Fix it.
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>

I've re-thought this problem.  I'm not seeing a better way to work
around this problem without further divergence from upstream on these
functions, so thanks for doing this!

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160120/77eabc7d/attachment.sig>


More information about the U-Boot mailing list