[U-Boot] [PATCH 1/2] checkpatch: ignore request to use ether_addr_copy()

Tom Rini trini at konsulko.com
Thu Jan 21 02:22:41 CET 2016


On Wed, Jan 20, 2016 at 02:04:04PM -0700, Stephen Warren wrote:
> On 01/20/2016 02:00 PM, Tom Rini wrote:
> >On Wed, Jan 20, 2016 at 01:47:55PM -0700, Stephen Warren wrote:
> >>On 01/13/2016 11:23 AM, Stephen Warren wrote:
> >>>On 12/15/2015 04:41 PM, Joe Hershberger wrote:
> >>>>Hi Stephen,
> >>>>
> >>>>On Tue, Dec 15, 2015 at 5:34 PM, Stephen Warren
> >>>><swarren at wwwdotorg.org> wrote:
> >>>>>On 11/23/2015 04:36 PM, Joe Hershberger wrote:
> >>>>>>
> >>>>>>On Fri, Nov 13, 2015 at 10:03 AM, Stephen Warren
> >>>>>><swarren at wwwdotorg.org>
> >>>>>>wrote:
> >>>>>>>
> >>>>>>>From: Stephen Warren <swarren at nvidia.com>
> >>>>>>>
> >>>>>>>The Linux kernel, from which checkpatch originates, contains function
> >>>>>>>ether_addr_copy() to copy Ethernet MAC addresses, and checkpatch warns
> >>>>>>>that it should be used in preference to memcpy() where appropriate.
> >>>>>>>U-Boot doesn't contain ether_addr_copy(), so tell checkpatch not to
> >>>>>>>issue
> >>>>>>>this warning.
> >>>>>>>
> >>>>>>>Signed-off-by: Stephen Warren <swarren at nvidia.com>
> >>>>>>
> >>>>>>
> >>>>>>Acked-by: Joe Hershberger <joe.hershberger at ni.com>
> >>>>>
> >>>>>
> >>>>>Were you intending someone else to apply this? I think now that Ted
> >>>>>Chen has
> >>>>>taken over the USB NIC driver (which was patch 2 in this series),
> >>>>>this patch
> >>>>>should be applied separately.
> >>>>
> >>>>It is assigned to Marek in patchwork. If he's not going to take it,
> >>>>then assign it to me and I'll pull it in.
> >>>
> >>>Marek,
> >>>
> >>>Are you taking this patch? If not, could you please re-assign it to Joe;
> >>>I don't believe I can modify patchwork myself.
> >>
> >>Marek?
> >>
> >>Tom, are you able to re-assign this patch to Joe in patchwork?
> >
> >Which? https://patchwork.ozlabs.org/patch/570547/ ?
> 
> Just patch 1/2 not 2/2:
> 
> https://patchwork.ozlabs.org/patch/544360/
> checkpatch: ignore request to use ether_addr_copy()

Ah, ok.  I've taken 1/2 but if Joe beats me to it (patchwork assignments
are suggestions) that's fine too.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160120/1aadbebc/attachment.sig>


More information about the U-Boot mailing list