[U-Boot] powerpc/83xx: fix build failure

Bin Meng bmeng.cn at gmail.com
Thu Jan 21 02:38:25 CET 2016


Hi Tom,

On Thu, Jan 21, 2016 at 9:27 AM, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Jan 21, 2016 at 09:22:43AM +0800, Bin Meng wrote:
>> Hi Tom,
>>
>> On Thu, Jan 21, 2016 at 5:01 AM, Tom Rini <trini at konsulko.com> wrote:
>> > On Thu, Jan 14, 2016 at 06:45:30PM +0800, Shengzhou Liu wrote:
>> >
>> >> Remove duplicated SDRAM_INTERVAL_BSTOPRE from mpc83xx.h,
>> >> which has been defined in fsl_ddr_sdram.h
>> >>
>> >> Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
>> >
>> > Applied to u-boot/master, thanks!
>>
>> IMHO, if it is a WIP, this patch should be squashed into the patch
>> which broke the build as it has not been merged upstream yet. Am I
>> missing anything?
>
> Mess-up on my part, but... SDRAM_INTERVAL_BSTOPRE isn't used _anywhere_
> only SDRAM_INTERVAL_BSTOPRE_SHIFT so nothing broke.
>

Yep, I just grep this and found nothing, which is different from what
I grepped last time. Something must have been merged upstream
recently. But if this is the case, then the commit title should really
say: powerpc/83xx: Remove useless SDRAM_INTERVAL_BSTOPRE instead of
saying 'fix build failure'.

Regards,
Bin


More information about the U-Boot mailing list