[U-Boot] [PATCH 0/8] Convert lpuart serial driver to driver model

[Simon Glass]

Hi,

On 12 January 2016 at 02:30, Bhuvanchandra DV
<bhuvanchandra.dv at toradex.com> wrote:
> Hi Bin,
>
>
> On 01/12/2016 12:21 PM, Bin Meng wrote:
>>
>> Hi Bhuvanchandra,
>>
>> On Tue, Jan 12, 2016 at 2:43 PM, Bhuvanchandra DV
>> <bhuvanchandra.dv at toradex.com> wrote:
>>>
>>> Hi Bin,
>>>
>>>
>>> On 01/12/2016 11:05 AM, Bin Meng wrote:
>>>>
>>>>
>>>> Hi Bhuvanchandra,
>>>>
>>>> On Tue, Jan 12, 2016 at 12:28 PM, Bhuvanchandra DV
>>>> <bhuvanchandra.dv at toradex.com> wrote:
>>>>>
>>>>>
>>>>> - Convert lpuart driver to driver model and remove the legacy code.
>>>>> - Update Toradex Colibri VF50/VF61 serial support with driver model.
>>>>> - Update Freescale vf610twr serial support with driver model.
>>>>> - Update Freescale ls1021atwr serial support with driver model.
>>>>> - Update Phytec pcm052 serial support with driver model.
>>>>> - Tested the driver on Toradex Colibri VF50/VF61 hardware.
>>>>> - Compile checked board files for vf610twr, ls1021atwr and pcm052
>>>>>     since I don't have access to such hardware at my end. Reviewers
>>>>>     and testers welcome!
>>>>>
>>>>> Bhuvanchandra DV (8):
>>>>>     dm: lpuart: Add driver model support for the serial driver
>>>>>     colibri_vf: Update enabling lpuart support with driver model
>>>>>     arm: vf610twr: Add driver model support
>>>>>     vf610twr: Update enabling lpuart with driver model
>>>>>     arm: ls102xa: Add driver model support
>>>>>     ls1021x: Update enabling lpuart with driver model
>>>>>     arm: pcm052: Enable driver model support
>>>>>     pcm052: Update enabling lpuart support with driver model
>>>>>
>>>>>    arch/arm/include/asm/arch-ls102xa/serial.h |  16 ++++
>>>>>    arch/arm/include/asm/arch-vf610/serial.h   |  16 ++++
>>>>>    board/freescale/ls1021atwr/ls1021atwr.c    |  15 ++-
>>>>>    board/freescale/vf610twr/vf610twr.c        |  13 +++
>>>>>    board/phytec/pcm052/pcm052.c               |  13 +++
>>>>>    board/toradex/colibri_vf/colibri_vf.c      |  13 +++
>>>>>    configs/ls1021atwr_nor_lpuart_defconfig    |   1 +
>>>>>    configs/pcm052_defconfig                   |   1 +
>>>>>    configs/vf610twr_defconfig                 |   1 +
>>>>>    configs/vf610twr_nand_defconfig            |   1 +
>>>>>    drivers/serial/Kconfig                     |   6 ++
>>>>>    drivers/serial/serial_lpuart.c             | 148
>>>>> +++++++++++++++--------------
>>>>>    include/configs/colibri_vf.h               |   6 +-
>>>>>    include/configs/ls1021atwr.h               |   1 +
>>>>>    include/configs/pcm052.h                   |   6 +-
>>>>>    include/configs/vf610twr.h                 |   6 +-
>>>>>    16 files changed, 180 insertions(+), 83 deletions(-)
>>>>>    create mode 100644 arch/arm/include/asm/arch-ls102xa/serial.h
>>>>>    create mode 100644 arch/arm/include/asm/arch-vf610/serial.h
>>>>>
>>>>> --
>>>>
>>>>
>>>>
>>>> Please see existing patch series @
>>>> http://patchwork.ozlabs.org/patch/561855/. You can drop the ls102xa
>>>> changes and rebase your patch series on top of that. Thanks!
>>>
>>>
>>>
>>> We are not aware of this patch set, sorry! about that. You want me to
>>> drop
>>> only the ls102xa changes? How about the changes/updates to the lpuart
>>> driver? should i update them with your device tree support stuff and
>>> rebase
>>> the remaining patch set along with your Signed-off-by tag ?
>>> Any suggestions ?
>>>
>>
>> I believe you can:
>> - Drop the LPUART DM conversion patch in your series, which was already
>> done
>
>
> I believe that the patch set[1] is now _only_ supporting device tree enabled
> boards, there are boards using lpuart which are not yet having device trees,
> boards like vf610twr and Phytec pcm052. Even with driver model enabled i
> guess these boards canont use lpuart via platform data with this patch set.
> I think it would be nice to have the support for both platform data and
> device tree so that we can use it with platform data via board files and
> device tree too.
>
> Since only few boards are using lpuart driver we can update the driver
> completly to driver model, drop the legacy code and update the boards.
>
> Seems the legacy code in lpuart driver is broken:
> drivers/serial/serial_lpuart.c:148:9: error: too few arguments to function
> '_lpuart_serial_tstc'
>
> I will test the patch set[1] atleast on Toradex Colibri VF50/VF61 h/w and
> will provide a detailed report of my observations.
>
>
> [1] http://patchwork.ozlabs.org/patch/561855/
>
>> - Drop the ls1021atwr changes, which was already done
>> - Do the similar changes to all other boards in your series, by
>> following ls1021atwr changes in my series
>> - There is no need to add my SOB tag in your series as I was actually
>> not doing anything :)

Please go ahead and post any new patches that are required here now
that Bin's series has landed.

Regards,
Simon