[U-Boot] [Patch V5 1/4] spi: fsl_qspi: fix compile warning for 64-bit platform

Qianyu Gong qianyu.gong at nxp.com
Fri Jan 22 05:08:34 CET 2016


> -----Original Message-----
> From: Scott Wood
> Sent: Friday, January 22, 2016 3:28 AM
> To: Qianyu Gong <qianyu.gong at nxp.com>; u-boot at lists.denx.de;
> R58495 at freescale.com
> Cc: Mingkai.Hu at freescale.com; jteki at openedev.com; B48286 at freescale.com;
> Shaohui.Xie at freescale.com; Wenbin.Song at freescale.com; Scott Wood
> <oss at buserror.net>; Gong Qianyu <Qianyu.Gong at freescale.com>
> Subject: Re: [Patch V5 1/4] spi: fsl_qspi: fix compile warning for 64-bit platform
> 
> On 01/20/2016 09:42 PM, Gong Qianyu wrote:
> > From: Gong Qianyu <Qianyu.Gong at freescale.com>
> >
> > This patch fixes the following compile warning:
> > drivers/spi/fsl_qspi.c: In function 'fsl_qspi_probe':
> > drivers/spi/fsl_qspi.c:937:15:
> >   warning: cast to pointer from integer of different size
> > 					 [-Wint-to-pointer-cast]
> >   priv->regs = (struct fsl_qspi_regs *)plat->reg_base;
> >                ^
> > Just make the cast explicit.
> >
> > Signed-off-by: Gong Qianyu <Qianyu.Gong at freescale.com>
> > ---
> > V5:
> >  - Use uintptr_t instead of unsigned long.
> > V4:
> >  - Revise the commit message.
> > V2-V3:
> >  - No change.
> >
> >  drivers/spi/fsl_qspi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index
> > 542b6cf..38e5900 100644
> > --- a/drivers/spi/fsl_qspi.c
> > +++ b/drivers/spi/fsl_qspi.c
> > @@ -936,7 +936,7 @@ static int fsl_qspi_probe(struct udevice *bus)
> >
> >  	dm_spi_bus->max_hz = plat->speed_hz;
> >
> > -	priv->regs = (struct fsl_qspi_regs *)plat->reg_base;
> > +	priv->regs = (struct fsl_qspi_regs *)(uintptr_t)plat->reg_base;
> >  	priv->flags = plat->flags;
> >
> >  	priv->speed_hz = plat->speed_hz;
> >
> 
> Use phys_to_virt().
> 
> -Scott

The function seems to be dropped in U-Boot? 
I just find it in arch/arm/include/asm/memory.h with ''#if 0''.

Regards,
Qianyu


More information about the U-Boot mailing list