[U-Boot] [PATCH] net : null check after pointer dereference

Vishwas Srivastava vishu.kernel at gmail.com
Tue Jan 26 08:26:09 CET 2016


Author: Vishwas Srivastava <vishu.kernel at gmail.com>
Date:   Tue Jan 26 12:46:42 2016 +0530

    null check after pointer dereference

    NULL check is made after the pointer dereference is davinci-
    emac driver. This patch fixes this issue.

    CC: Sergey Kubushyn <ksi at koi8.net>;Joe Hershberger <
joe.hershberger at ni.com>
    Signed-off-by: Vishwas Srivastava <vishu.kernel at gmail.com>

diff --git a/drivers/net/davinci_emac.c b/drivers/net/davinci_emac.c
index 3f54a3f..1966eb9 100644
--- a/drivers/net/davinci_emac.c
+++ b/drivers/net/davinci_emac.c
@@ -692,8 +692,10 @@ static int davinci_eth_rcv_packet (struct eth_device
*dev)
        davinci_invalidate_rx_descs();

        rx_curr_desc = emac_rx_active_head;
+       if (!rx_curr_desc)
+           return 0;
        status = rx_curr_desc->pkt_flag_len;
-       if ((rx_curr_desc) && ((status & EMAC_CPPI_OWNERSHIP_BIT) == 0)) {
+       if ((status & EMAC_CPPI_OWNERSHIP_BIT) == 0) {
                if (status & EMAC_CPPI_RX_ERROR_FRAME) {
                        /* Error in packet - discard it and requeue desc */
                        printf ("WARN: emac_rcv_pkt: Error in packet\n");


More information about the U-Boot mailing list