[U-Boot] [PATCH 3/3] board: atmel: siemens: clean up PLLB code

Andreas Bießmann andreas.devel at googlemail.com
Tue Jan 26 16:38:30 CET 2016


On 09.12.2015 05:29, Wenyou Yang wrote:
> Due to introducing the new PLLB clock handle functions,
> use these functions to clean up the PLLB enable code.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>

Reviewed-by: Andreas Bießmann <andreas.devel at googlemail.com>

> ---
> 
>  board/siemens/smartweb/smartweb.c |    6 +-----
>  board/siemens/taurus/taurus.c     |    6 +-----
>  2 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/board/siemens/smartweb/smartweb.c b/board/siemens/smartweb/smartweb.c
> index e7ee65c..47a60a7 100644
> --- a/board/siemens/smartweb/smartweb.c
> +++ b/board/siemens/smartweb/smartweb.c
> @@ -115,12 +115,8 @@ static void smartweb_macb_hw_init(void)
>  
>  void at91_udp_hw_init(void)
>  {
> -	at91_pmc_t *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
> -
>  	/* Enable PLLB */
> -	writel(get_pllb_init(), &pmc->pllbr);
> -	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
> -		;
> +	at91_pllb_clk_enable(get_pllb_init());
>  
>  	/* Enable UDPCK clock, MCK is enabled in at91_clock_init() */
>  	at91_periph_clk_enable(ATMEL_ID_UDP);
> diff --git a/board/siemens/taurus/taurus.c b/board/siemens/taurus/taurus.c
> index 9374064..b0385d8 100644
> --- a/board/siemens/taurus/taurus.c
> +++ b/board/siemens/taurus/taurus.c
> @@ -289,12 +289,8 @@ void spi_cs_deactivate(struct spi_slave *slave)
>  
>  void at91_udp_hw_init(void)
>  {
> -	at91_pmc_t *pmc = (at91_pmc_t *)ATMEL_BASE_PMC;
> -
>  	/* Enable PLLB */
> -	writel(get_pllb_init(), &pmc->pllbr);
> -	while ((readl(&pmc->sr) & AT91_PMC_LOCKB) != AT91_PMC_LOCKB)
> -		;
> +	at91_pllb_clk_enable(get_pllb_init());
>  
>  	/* Enable UDPCK clock, MCK is enabled in at91_clock_init() */
>  	at91_periph_clk_enable(ATMEL_ID_UDP);
> 



More information about the U-Boot mailing list