[U-Boot] Banan Pro (ahci-sunxi) SATA port stopped working after switching to U-Boot v2016.01

[Hans de Goede]

Hi,

On 01/22/2016 03:07 PM, Hans de Goede wrote:
> Hi,
>
> On 21-01-16 00:34, Markus Baier wrote:
>> Am 19.01.2016 um 18:12 schrieb Tom Rini:
>>  > On Sun, Jan 17, 2016 at 09:44:53PM +0100, Markus Baier wrote:
>>  >
>>  >> Hello,
>>  >>
>>  >> tonight I switched  to the new U-Boot v2016.01
>>  >> on my Banana Pro system.
>>  >> I compiled u-boot, like I did with all the working
>>  >> versions before, with:
>>  >> make Bananapro_defconfig
>>  >> make
>>  >>
>>  >> But with the new U-Boot installed the SATA Port
>>  >> did not work anymore.
>>  >> The Kernel is the same 4.0.9-gentoo as I used before
>>  >> with the last U-Boot Release v2015.10
>>  >>
>>  >> dmesg show me the following error in the kernel log:
>>  >> [    1.925032] ahci-sunxi 1c18000.sata: PHY power up failed.
>>  >> [    1.930661] ahci-sunxi: probe of 1c18000.sata failed with error -5
>>  >>
>>  >> I also see now SATA message at the U-Boot bootscreen,
>>  >> the v2015.10 shows me that a SATA Port was recognized
>>  >> by the U-Boot loader.
>>  >
>>  > Can you please use git bisect to determine which commit broke this?
>>  > Thanks!
>>
>> Hi,
>>
>> thanks for the advice, I have found the bad commit,
>> it is -> 02cc27c74f9b884b538bcd1b93342a4c05b5d608
>> sunxi: power: Change axp209 LDO3 and LDO4 default to disabled
>>
>> after that I tried the v2016.01 release again, but changed
>> the two lines in config AXP_ALDO3_VOLT and config AXP_ALDO4_VOLT
>> back to their old values, now the SATA Port is working again.
>
> Thanks for debugging this, according to the Bananapro schematic
> VDD25-SATA either comes from a dedicated WL2003E25-5 linear regulator,
> or it is connected to LDO4 via a 0 Ohm resistor.
>
> So it would seem that in practice it seems that LDO4 is used, can you
> give the attached patch a try ?

I had access to a bananapro board myself today, and I can confirm that
the patch I wrote fixes this.

Regards,

Hans