[U-Boot] [PATCH] test/py: make crash detection more robust

Simon Glass sjg at chromium.org
Fri Jan 29 05:01:49 CET 2016


On 25 January 2016 at 18:17, Simon Glass <sjg at chromium.org> wrote:
> Hi Stephen,
>
> On 25 January 2016 at 18:11, Stephen Warren <swarren at wwwdotorg.org> wrote:
>> On 01/25/2016 06:07 PM, Simon Glass wrote:
>>>
>>> Hi Stephen,
>>>
>>> On 25 January 2016 at 15:07, Stephen Warren <swarren at wwwdotorg.org> wrote:
>>>>
>>>> From: Stephen Warren <swarren at nvidia.com>
>>>>
>>>> test/py contains logic to detect the target crashing and rebooting by
>>>> searching the console output for a U-Boot signon message, which will
>>>> presumably be emitted when the system boots after the crash/reset.
>>>>
>>>> Currently, this logic only searches for the exact signon message that
>>>> was printed by the U-Boot version under test, upon the assumption that
>>>> binary is written into flash, and hence will be the version booted after
>>>> any reset. However, this is not a valid assumption; some test setups
>>>> download the U-Boot-under-test into RAM and boot it from there, and in
>>>> such a scenario an arbitrary U-Boot version may be located in flash and
>>>> hence run after any reset.
>>>>
>>>> Fix the reset detection logic to match any U-Boot signon message. This
>>>> prevents false negatives.
>>>>
>>>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>>>> ---
>>>>   test/py/u_boot_console_base.py | 20 +++++++-------------
>>>>   1 file changed, 7 insertions(+), 13 deletions(-)

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list