[U-Boot] [PATCH 3/6] video: Use 'int' for loop variables instead of short

Simon Glass sjg at chromium.org
Sat Jan 30 23:45:16 CET 2016


Using short doesn't save anything and is confusing when the width and height
variables are ulong.

This may fix Coverity CID134902 but I doubt it.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 drivers/video/video_bmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/video_bmp.c b/drivers/video/video_bmp.c
index c9075d6..fb7943e 100644
--- a/drivers/video/video_bmp.c
+++ b/drivers/video/video_bmp.c
@@ -194,7 +194,7 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 {
 	struct video_priv *priv = dev_get_uclass_priv(dev);
 	ushort *cmap_base = NULL;
-	ushort i, j;
+	int i, j;
 	uchar *fb;
 	struct bmp_image *bmp = map_sysmem(bmp_image, 0);
 	uchar *bmap;
-- 
2.7.0.rc3.207.g0ac5344



More information about the U-Boot mailing list