[U-Boot] [PATCH] clk: convert API to match reset/mailbox style

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Thu Jun 2 19:48:35 CEST 2016


Hi Stephen,

2016-06-02 19:00 GMT+02:00 Stephen Warren <swarren at wwwdotorg.org>:
> On 05/23/2016 11:47 AM, Stephen Warren wrote:
>>
>> From: Stephen Warren <swarren at nvidia.com>
>>
>> The following changes are made to the clock API:
>> * The concept of "clocks" and "peripheral clocks" are unified; each clock
>>    provider now implements a single set of clocks. This provides a simpler
>>    conceptual interface to clients, and better aligns with device tree
>>    clock bindings.
>> * Clocks are now identified with a single "struct clk", rather than
>>    requiring clients to store the clock provider device and clock identity
>>    values separately. For simple clock consumers, this isolates clients
>>    from internal details of the clock API.
>> * clk.h is split into clk_client.h and clk_uclass.h to make it obvious
>>    which parts are relevant to consumers and providers. This aligns with
>>    the recently added reset and mailbox APIs.
>> * clk_ops .of_xlate(), .request(), and .free() are added so providers
>>    can customize these operations if needed. This also aligns with the
>>    recently added reset and mailbox APIs.
>> * clk_disable() is added.
>> * All users of the current clock APIs are updated.
>> * Sandbox clock tests are updated to exercise clock lookup via DT, and
>>    clock enable/disable.
>> * rkclk_get_clk() is removed and replaced with standard APIs.
>>
>> Buildman shows no clock-related errors for any board for which buildman
>> can download a toolchain.
>>
>> test/py passes for sandbox (which invokes the dm clk test amongst
>> others).
>
>
> Simon, does this look good?
>

could you rebase the patch to current mainline?. I couldn't apply it
some days ago. Thanks.

-- 
- Daniel


More information about the U-Boot mailing list