[U-Boot] [PATCH] clk: convert API to match reset/mailbox style

Simon Glass sjg at chromium.org
Thu Jun 2 23:20:10 CEST 2016


Hi Stephen,

On 3 June 2016 at 05:00, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 05/23/2016 11:47 AM, Stephen Warren wrote:
>>
>> From: Stephen Warren <swarren at nvidia.com>
>>
>> The following changes are made to the clock API:
>> * The concept of "clocks" and "peripheral clocks" are unified; each clock
>>    provider now implements a single set of clocks. This provides a simpler
>>    conceptual interface to clients, and better aligns with device tree
>>    clock bindings.
>> * Clocks are now identified with a single "struct clk", rather than
>>    requiring clients to store the clock provider device and clock identity
>>    values separately. For simple clock consumers, this isolates clients
>>    from internal details of the clock API.
>> * clk.h is split into clk_client.h and clk_uclass.h to make it obvious
>>    which parts are relevant to consumers and providers. This aligns with
>>    the recently added reset and mailbox APIs.
>> * clk_ops .of_xlate(), .request(), and .free() are added so providers
>>    can customize these operations if needed. This also aligns with the
>>    recently added reset and mailbox APIs.
>> * clk_disable() is added.
>> * All users of the current clock APIs are updated.
>> * Sandbox clock tests are updated to exercise clock lookup via DT, and
>>    clock enable/disable.
>> * rkclk_get_clk() is removed and replaced with standard APIs.
>>
>> Buildman shows no clock-related errors for any board for which buildman
>> can download a toolchain.
>>
>> test/py passes for sandbox (which invokes the dm clk test amongst
>> others).
>
>
> Simon, does this look good?
>
> (Note I'll be away on vacation Jun 4-15 so won't be able to respond for a
> while)

I am back next week, so will take a look then. I will give it a try on
the rockchip device.

Regards,
Simon


More information about the U-Boot mailing list