[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid
B, Ravi
ravibabu at ti.com
Fri Jun 3 09:51:43 CEST 2016
Hi Tom
>> Avoid use of hard coded mmcdev value so finduuid works based on
>> current mmcdev selected.
>>
>> Signed-off-by: Ravi Babu <ravibabu at ti.com>
>> ---
>> include/configs/ti_armv7_common.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/ti_armv7_common.h
>> b/include/configs/ti_armv7_common.h
>> index 7db0881..bbff06b 100644
>> --- a/include/configs/ti_armv7_common.h
>> +++ b/include/configs/ti_armv7_common.h
>> @@ -59,7 +59,7 @@
>> #define DEFAULT_MMC_TI_ARGS \
>> "mmcdev=0\0" \
>> "mmcrootfstype=ext4 rootwait\0" \
>> - "finduuid=part uuid mmc 0:2 uuid\0" \
>> + "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
>> "args_mmc=run finduuid;setenv bootargs console=${console} " \
>> "${optargs} " \
>> "root=PARTUUID=${uuid} rw " \
>Good, but incomplete find. am33xx doesn't, but other TI families do, "common"-out the bootpart variable and this is what should be used here, after making sure everyone that uses this has a bootpart set.
If I understand you correctly, are you saying to use *bootpart* as common variable and define "bootpart=${mmcdev}:2"
But you cannot define "bootpart=${mmcdev}:2" like this and use ${bootpart} in finduuid.
"finduuid=part uuid mmc ${bootpart} uuid\0" - this will _NOT_ work.
In order to make finduuid work, bootpart must be hard coded with mmcdev:partition as "bootpart=0:2" or "bootpart=1:2".
Please correct me if I understood your idea correctly.
Regards
Ravi
More information about the U-Boot
mailing list