[U-Boot] [PATCH] ti_armv7_common: env: Fix hard coded mmc device for uuid

B, Ravi ravibabu at ti.com
Fri Jun 3 16:18:23 CEST 2016


Hi Tom

>> diff --git a/include/configs/ti_armv7_common.h 
>> b/include/configs/ti_armv7_common.h
>> index 7db0881..bbff06b 100644
>> --- a/include/configs/ti_armv7_common.h
>> +++ b/include/configs/ti_armv7_common.h
>> @@ -59,7 +59,7 @@
>>  #define DEFAULT_MMC_TI_ARGS \
>>  	"mmcdev=0\0" \
>>  	"mmcrootfstype=ext4 rootwait\0" \
>> -	"finduuid=part uuid mmc 0:2 uuid\0" \
>> +	"finduuid=part uuid mmc ${bootpart} uuid\0" \
>>  	"args_mmc=run finduuid;setenv bootargs console=${console} " \
>>  		"${optargs} " \
>>  		"root=PARTUUID=${uuid} rw " \

>Right.  But not everyone that uses ti_armv7_common.h and DEFAULT_MMC_TI_ARGS has bootpart set I believe.  Use buildman to build all of the TI stuff and run 'strings' on u-boot.img to find cases of 'part uuid' but not having bootpart set.

Yes, you are correct, not all platform uses ti_armv7_common.h, bootpart is defined as part of DEFAULT_MMC_TI_ARGS.
I have run 'strings' on u-boot.img,  I did not find 'part uuid' without ${bootpart}. 

I will post rework of this patch (v1).  Thanks for review.

Regards
Ravi


More information about the U-Boot mailing list