[U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver

Scott Wood oss at buserror.net
Mon Jun 6 19:56:48 CEST 2016


On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote:
> On Mon, 6 Jun 2016 17:36:10 +0200
> Hans de Goede <hdegoede at redhat.com> wrote:
> 
> > > +#ifndef CONFIG_SPL_BUILD
> > > +void sunxi_nand_init(void);
> > > +#endif
> > > +  
> > 
> > Can we have this in a header somewhere please, and without
> > the #ifdef around it, that is not necessary for prototypes.
> 
> Hehe, I was expecting this one :-). Do you know where I should put this
> prototype definition? A board.h file in board/sunxi/?

It's defined in drivers/mtd/nand and called from board/sunxi so the prototype
needs to go somewhere under include/.  It can go in include/configs/sunxi
-common.h with #ifndef __ASSEMBLY__ around it -- or as long as it's limited to
one init func per driver, maybe we could just put it in include/nand.h.

-Scott



More information about the U-Boot mailing list