[U-Boot] [PATCH v4 2/2] USB: DWC2: choose 8-bit phy bus width

[Steve Rae]

On Tue, Jun 7, 2016 at 3:24 PM, Marek Vasut <marex at denx.de> wrote:
> On 06/07/2016 05:57 PM, Steve Rae wrote:
>> The Kona PHY supports an 8-bit wide UTMI interface,
>> therefore, choose this Kconfig setting.
>>
>> Signed-off-by: Steve Rae <srae at broadcom.com>
>
> Shouldn't the tags in this patch be ARM: bcm: ? They certainly shouldn't
> be USB: DWC2 as this affects the BCM platforms.
>
> Otherwise OK, thanks!
OK -- Thank you....
>
>> ---
>> from [1] (line ~124)
>>
>>     /* The Kona PHY supports an 8-bit wide UTMI interface */
>>     [...snip...]
>>
>>     module_platform_driver(bcm_kona_usb2_driver);
>>
>>     MODULE_ALIAS("platform:bcm-kona-usb2");
>>     MODULE_AUTHOR("Matt Porter <mporter at linaro.org>");
>>     MODULE_DESCRIPTION("BCM Kona USB 2.0 PHY driver");
>>     MODULE_LICENSE("GPL v2");
>>
>> [1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/phy/phy-bcm-kona-usb2.c
>>
>> Changes in v4:
>> - added this patch
>>
>> Changes in v3: None
>> Changes in v2: None
>>
>>  configs/bcm11130_defconfig      | 1 +
>>  configs/bcm11130_nand_defconfig | 1 +
>>  configs/bcm28155_ap_defconfig   | 1 +
>>  configs/bcm28155_w1d_defconfig  | 1 +
>>  4 files changed, 4 insertions(+)
>>
>> diff --git a/configs/bcm11130_defconfig b/configs/bcm11130_defconfig
>> index b8ec8ac..2716868 100644
>> --- a/configs/bcm11130_defconfig
>> +++ b/configs/bcm11130_defconfig
>> @@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
>>  CONFIG_USB=y
>>  CONFIG_USB_GADGET=y
>>  CONFIG_USB_GADGET_DWC2_OTG=y
>> +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
>>  CONFIG_USB_GADGET_DOWNLOAD=y
>>  CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
>>  CONFIG_G_DNL_VENDOR_NUM=0x18d1
>> diff --git a/configs/bcm11130_nand_defconfig b/configs/bcm11130_nand_defconfig
>> index 6021fd2..8e01c52 100644
>> --- a/configs/bcm11130_nand_defconfig
>> +++ b/configs/bcm11130_nand_defconfig
>> @@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
>>  CONFIG_USB=y
>>  CONFIG_USB_GADGET=y
>>  CONFIG_USB_GADGET_DWC2_OTG=y
>> +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
>>  CONFIG_USB_GADGET_DOWNLOAD=y
>>  CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
>>  CONFIG_G_DNL_VENDOR_NUM=0x18d1
>> diff --git a/configs/bcm28155_ap_defconfig b/configs/bcm28155_ap_defconfig
>> index 4404f32..eb58401 100644
>> --- a/configs/bcm28155_ap_defconfig
>> +++ b/configs/bcm28155_ap_defconfig
>> @@ -17,6 +17,7 @@ CONFIG_SYS_NS16550=y
>>  CONFIG_USB=y
>>  CONFIG_USB_GADGET=y
>>  CONFIG_USB_GADGET_DWC2_OTG=y
>> +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
>>  CONFIG_USB_GADGET_DOWNLOAD=y
>>  CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
>>  CONFIG_G_DNL_VENDOR_NUM=0x18d1
>> diff --git a/configs/bcm28155_w1d_defconfig b/configs/bcm28155_w1d_defconfig
>> index 60eb328..35d04af 100644
>> --- a/configs/bcm28155_w1d_defconfig
>> +++ b/configs/bcm28155_w1d_defconfig
>> @@ -18,6 +18,7 @@ CONFIG_SYS_NS16550=y
>>  CONFIG_USB=y
>>  CONFIG_USB_GADGET=y
>>  CONFIG_USB_GADGET_DWC2_OTG=y
>> +CONFIG_USB_GADGET_DWC2_OTG_PHY_BUS_WIDTH_8=y
>>  CONFIG_USB_GADGET_DOWNLOAD=y
>>  CONFIG_G_DNL_MANUFACTURER="Broadcom Corporation"
>>  CONFIG_G_DNL_VENDOR_NUM=0x18d1
>>
>
>
> --
> Best regards,
> Marek Vasut