[U-Boot] [PATCH] imx6: Add Phytec PCM058 i.MX6 Quad

[Fabio Estevam]

Hi Stefano,

On Mon, Jun 6, 2016 at 6:49 AM, Stefano Babic <sbabic at denx.de> wrote:

> diff --git a/board/phytec/pcm058/README b/board/phytec/pcm058/README
> new file mode 100644
> index 0000000..90e2818
> --- /dev/null
> +++ b/board/phytec/pcm058/README
> @@ -0,0 +1,9 @@
> +Building U-Boot for phytec-mira
> +-------------------------------
> +
> +There are two versions of the board (NAND or eMMC).
> +
> +To build for NAND:
> +
> +$ make phytec_mira_defconfig

This patch does not add the phytec_mira_defconfig file, so please fix
the readme accordingly.

> +int board_spi_cs_gpio(unsigned bus, unsigned cs)
> +{
> +       if (bus != 0 || (cs != 0))
> +               return -1;

return -EINVAL?

> +int board_init(void)
> +{
> +       /* address of boot parameters */
> +       gd->bd->bi_boot_params = PHYS_SDRAM + 0x100;
> +
> +#if 1

#ifdef CONFIG_SYS_I2C_MXC ?

> +       setup_i2c(2, CONFIG_SYS_I2C_SPEED, 0x7f, &i2c_pad_info2);
> +#endif


> +const struct mx6dq_iomux_ddr_regs mx6_ddr_ioregs = {

static?

> +       .dram_sdclk_0 = 0x00000030,
> +       .dram_sdclk_1 = 0x00000030,
> +       .dram_cas = 0x00000030,
> +       .dram_ras = 0x00000030,
> +       .dram_reset = 0x00000030,
> +       .dram_sdcke0 = 0x00000030,
> +       .dram_sdcke1 = 0x00000030,
> +       .dram_sdba2 = 0x00000000,
> +       .dram_sdodt0 = 0x00000030,
> +       .dram_sdodt1 = 0x00000030,
> +       .dram_sdqs0 = 0x00000030,
> +       .dram_sdqs1 = 0x00000030,
> +       .dram_sdqs2 = 0x00000030,
> +       .dram_sdqs3 = 0x00000030,
> +       .dram_sdqs4 = 0x00000030,
> +       .dram_sdqs5 = 0x00000030,
> +       .dram_sdqs6 = 0x00000030,
> +       .dram_sdqs7 = 0x00000030,
> +       .dram_dqm0 = 0x00000030,
> +       .dram_dqm1 = 0x00000030,
> +       .dram_dqm2 = 0x00000030,
> +       .dram_dqm3 = 0x00000030,
> +       .dram_dqm4 = 0x00000030,
> +       .dram_dqm5 = 0x00000030,
> +       .dram_dqm6 = 0x00000030,
> +       .dram_dqm7 = 0x00000030,
> +};
> +
> +const struct mx6dq_iomux_grp_regs mx6_grp_ioregs = {

static?

> +       .grp_ddr_type =  0x000C0000,
> +       .grp_ddrmode_ctl =  0x00020000,
> +       .grp_ddrpke =  0x00000000,
> +       .grp_addds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_ctlds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_ddrmode =  0x00020000,
> +       .grp_b0ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b1ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b2ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b3ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b4ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b5ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b6ds = IMX6Q_DRIVE_STRENGTH,
> +       .grp_b7ds = IMX6Q_DRIVE_STRENGTH,
> +};
> +
> +const struct mx6_mmdc_calibration mx6_mmcd_calib = {

static?

> --- /dev/null
> +++ b/include/configs/pcm058.h
> @@ -0,0 +1,140 @@
> +/*
> + * Copyright (C) Stefano Babic <sbabic at denx.de>
> + *
> + * SPDX-License-Identifier:    GPL-2.0+
> + */
> +
> +
> +#ifndef __PHYBOARD_MIRA_CONFIG_H
> +#define __PHYBOARD_MIRA_CONFIG_H

There is no "mira" in the file name.