[U-Boot] [PATCH RESEND 2/2 v2] lib: Add hexdump

Alexey Brodkin alexey.brodkin at gmail.com
Fri Jun 10 22:49:03 CEST 2016


Hi Tom,

On Fri, 2016-06-10 at 15:22 -0400, Tom Rini wrote:
> On Fri, Jun 10, 2016 at 03:42:31PM +0300, Alexey Brodkin wrote:
> 
> > 
> > Often during debugging session it's very interesting to see
> > what data we were dealing with. For example what we write or read
> > to/from memory or peripherals.
> > 
> > This change introduces functions that allow to dump binary
> > data with one simple function invocation like:
> Reviewed-by: Tom Rini <trini at konsulko.com>
> 
> ... except adding to <common.h>.  Do we really need it placed in there?
> 

Rationale behind it was to keep a minimal amount of changes.
I mean those mentioned existing "users" of hexdump will require
explicit mention of that new header which I wanted to escape.

Still I may agree with proposal to remove hexdump.h from common.h...
if we're going to accept this patch at all [in any form]...

-Alexey


More information about the U-Boot mailing list