[U-Boot] [PATCH] sunxi: Revert "sunxi: make SoC variant choice mandatory"

Hans de Goede hdegoede at redhat.com
Sun Jun 12 19:50:20 CEST 2016


Hi,

On 12-06-16 14:25, Ian Campbell wrote:
> On Sun, 2016-06-12 at 13:03 +0200, Hans de Goede wrote:
>> This reverts commit 1a5f0de08e86("sunxi: make SoC variant choice
>> mandatory").
>>
>> With the optional marking in the Kconfig "make savedefconfig"
>> will drop CONFIG_MACH_SUN4I=y from all the A10 boards, making it
>> hard to see at a glance which family of sunxi chips the defconfig
>> is for.
>>
>> This commit therefore restores the optional, and restores
>> CONFIG_MACH_SUN4I=y to all defconfig's which had it dropped
>> because of this.
>
> Is this because the first config in a choice is considered the default
> and hence is omitted by savedefconfig

Yes, exactly.

> or is something else going on?
>
> In any case:
>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>
> Acked-by: Ian Campbell <ijc at hellion.org.uk>

Thanks for all the reviews!

Regards,

Hans


p.s.

I've just send out another patch for a new board


More information about the U-Boot mailing list